feat: add `math/base/special/croundnf` #9632

Amansingh0807 · 2026-01-08T18:33:53Z

Resolves None

Description

What is the purpose of this pull request?

This pull request:

This PR adds math/base/special/croundnf.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

stdlib-bot · 2026-01-08T18:36:42Z

Coverage Report

Package	Statements	Branches	Functions	Lines
math/base/special/croundnf	$\color{green}190/190$ $\color{green}+0.00%$	$\color{green}5/5$ $\color{green}+0.00%$	$\color{green}2/2$ $\color{green}+0.00%$	$\color{green}190/190$ $\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

…rrors

Planeshifter

Thanks for adding croundnf! The implementation looks good overall. I found one issue that needs to be addressed before this can be merged - the native addon build will fail due to a missing dependency in manifest.json. See the inline comment for details.

Planeshifter · 2026-01-13T06:29:23Z

lib/node_modules/@stdlib/math/base/special/croundnf/manifest.json

+      "dependencies": [
+        "@stdlib/math/base/napi/binary",
+        "@stdlib/math/base/special/roundnf",
+        "@stdlib/complex/float32/ctor",
+        "@stdlib/complex/float32/real",
+        "@stdlib/complex/float32/imag"
+      ]


The "build" task is missing @stdlib/complex/float32/reim as a dependency. The C implementation in src/main.c includes stdlib/complex/float32/reim.h and calls stdlib_complex64_reim(), so this dependency is needed for the native addon to build correctly.

Looking at the equivalent @stdlib/math/base/special/croundn package, its "build" task includes @stdlib/complex/float64/reim in the dependencies.

Suggested change

"dependencies": [

"@stdlib/math/base/napi/binary",

"@stdlib/math/base/special/roundnf",

"@stdlib/complex/float32/ctor",

"@stdlib/complex/float32/real",

"@stdlib/complex/float32/imag"

]

"dependencies": [

"@stdlib/math/base/napi/binary",

"@stdlib/math/base/special/roundnf",

"@stdlib/complex/float32/ctor",

"@stdlib/complex/float32/reim",

"@stdlib/complex/float32/real",

"@stdlib/complex/float32/imag"

]

Amansingh0807 · 2026-01-13T08:20:43Z

Thanks for catching this, @Planeshifter! I've added @stdlib/complex/float32/reim to the build dependencies. The fix has been pushed.

Planeshifter · 2026-01-13T16:41:21Z

lib/node_modules/@stdlib/math/base/special/croundnf/lib/native.js

+
+// MODULES //
+
+var addon = require( './../src/addon.node' );


This needs to wrap the addon result in a Complex64 instance to match the documented return type and other similar packages like croundn and cceiln. Currently it returns the raw object from the addon (with .re and .im properties) instead of a proper Complex64 instance.

You'll also need to add the Complex64 import at the top of the file.

Suggested change

var addon = require( './../src/addon.node' );

var Complex64 = require( '@stdlib/complex/float32/ctor' );

var addon = require( './../src/addon.node' );

Planeshifter · 2026-01-13T16:41:31Z

lib/node_modules/@stdlib/math/base/special/croundnf/lib/native.js

+// MAIN //
+
+/**
+* Rounds each component of a single-precision complex floating-point number to the nearest multiple of \\(10^n\\).


Let's use backticks here instead of LaTeX notation to match the style in croundn/lib/native.js and other lib files:

Suggested change

* Rounds each component of a single-precision complex floating-point number to the nearest multiple of \$10^n\$.

* Rounds each component of a single-precision complex floating-point number to the nearest multiple of `10^n`.

Planeshifter · 2026-01-13T16:41:32Z

lib/node_modules/@stdlib/math/base/special/croundnf/lib/native.js

+function croundnf( z, n ) {
+	return addon( z, n );
+}


This should wrap the addon result in a Complex64 instance:

Suggested change

function croundnf( z, n ) {

return addon( z, n );

}

function croundnf( z, n ) {

var v = addon( z, n );

return new Complex64( v.re, v.im );

}

Planeshifter · 2026-01-13T16:41:39Z

lib/node_modules/@stdlib/math/base/special/croundnf/manifest.json

+      "libraries": [
+        "-lm"


The -lm flag isn't needed here since this package doesn't directly use math.h functions - it delegates to roundnf which handles that dependency in its own manifest.

Suggested change

"libraries": [

"-lm"

"libraries": [],

Planeshifter · 2026-01-13T16:41:44Z

lib/node_modules/@stdlib/math/base/special/croundnf/manifest.json

+      "libraries": [
+        "-lm"


Same here - should be empty:

Suggested change

"libraries": [

"-lm"

"libraries": [],

Planeshifter · 2026-01-13T16:41:50Z

lib/node_modules/@stdlib/math/base/special/croundnf/manifest.json

+      "libraries": [
+        "-lm"
+      ],


And here too:

Suggested change

"libraries": [

"-lm"

],

"libraries": [],

…necessary -lm flags

feat: add math/base/special/croundnf

6740951

stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Jan 8, 2026

fix: use intermediate variable to avoid function-paren-newline lint e…

d956042

…rrors

Planeshifter self-requested a review January 13, 2026 06:21

Planeshifter requested changes Jan 13, 2026

View reviewed changes

fix: add missing @stdlib/complex/float32/reim dependency to build task

1f122b1

Planeshifter requested changes Jan 13, 2026

View reviewed changes

fix: wrap addon result in Complex64, use backtick notation, remove un…

4b732ae

…necessary -lm flags

Amansingh0807 requested a review from Planeshifter January 14, 2026 06:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `math/base/special/croundnf` #9632

feat: add `math/base/special/croundnf` #9632

Amansingh0807 commented Jan 8, 2026

Uh oh!

stdlib-bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Jan 13, 2026

Uh oh!

Amansingh0807 commented Jan 13, 2026

Uh oh!

Planeshifter Jan 13, 2026

Uh oh!

Planeshifter Jan 13, 2026

Uh oh!

Planeshifter Jan 13, 2026

Uh oh!

Planeshifter Jan 13, 2026

Uh oh!

Planeshifter Jan 13, 2026

Uh oh!

Planeshifter Jan 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	var addon = require( './../src/addon.node' );
	var Complex64 = require( '@stdlib/complex/float32/ctor' );
	var addon = require( './../src/addon.node' );

	* Rounds each component of a single-precision complex floating-point number to the nearest multiple of \\(10^n\\).
	* Rounds each component of a single-precision complex floating-point number to the nearest multiple of `10^n`.

Uh oh!

feat: add math/base/special/croundnf #9632

Are you sure you want to change the base?

feat: add math/base/special/croundnf #9632

Conversation

Amansingh0807 commented Jan 8, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

stdlib-bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Amansingh0807 commented Jan 13, 2026

Uh oh!

Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: add `math/base/special/croundnf` #9632

feat: add `math/base/special/croundnf` #9632

stdlib-bot commented Jan 8, 2026 •

edited

Loading